To stac #617
Merged
To stac #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only dataframe test works
for now the testing is done manually. Perhaps when the from functionality is added we'll want to add it again.
Jaapel
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks great, some minor comments.
For inspiration, (this is STAC -> DaskDataArray, but still deals with the same ecosystem). https://stackstac.readthedocs.io/en/latest/basic.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #405
Explanation
Implement the
to_stacfunctionality for hydromt data catalog and adapters. Since HydroMT has some functionality that STAC doesn't support this does lead to some loss in information. We can add extensions to remedy this later, but for this first go I thought it was best to just make an MVP and see what else is necessary before moving on.Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.